-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix : Fix ESM exports #441
Conversation
Thank you, it works fine :) |
Can verify this fixes #440 |
Probably good advice to not release major changes which accidentally do break things on / close to NYE 😂 |
ping @eXon (in case you don't get notified) . This issue is blocking typescript builds, needing to go back to old version . Can you at least allow workflow so I can check if the tests are passing on your Ci ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Would it be possible to also do the same change for all packages, not only universal-cookie?
@eXon can you re-allow the workflow please ? ( I will try to run tests, but scripts are not compatible with windows, and running them in wsl is extremely slow ) ( I will rebase the commits if the tests works ) Because the git hooks doesn't work on windows, I need to do it on wsl, and so the commit is not signed |
@thib3113 Would it be possible to resign your commit using Windows by skipping the pre-commit hook? You can do something like this: |
@thib3113 Thank you for your contribution! I should be able to release 7.0.1 by tomorrow. |
V7.0.0 breaks typescript because of the exports, Fix #440
So, I update them like :
I also added default for bundler that doesn't handle import or require .
( in general, I also use .cjs extension for cjs files, and .cts for cjs typing, but maybe not needed for an hotfix )